Fedor Karpelevitch <[EMAIL PROTECTED]> writes: > I just looked at it and it is not threadsafe at all - it stores a lot of > state in instance vars. So calls should either be synchronized or you should > create a new instance each time (or keep one instance per thread, but it > would be PITA to maintain...)
Using a ThreadLocal variable would handle that fairly easily (though to those unfamiliar with the ThreadLocal class, it makes the code harder to read, as you say), but I'm unsure whether it would be a net performance gain or not (we should really run a test to be sure). What do you think, Fedor? - Dan -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
