On Tue, 2002-04-02 at 14:41, Chris Kimpton wrote:
> Hi,
> 
> --- Eric Dobbs <[EMAIL PROTECTED]> wrote:
> > On Tuesday, April 2, 2002, at 08:16  AM, Chris Kimpton wrote:
> > 
> > >> I would prefer to do
> > >> this with an explicit configuration entry in
> > >> TurbineResources.properties like this:
> > >>
> > >> component.fulcrum.property.webappRoot=${webappRoot}
> > >> component.fulcrum.property.applicationRoot=${applicationRoot}
> > >>
> > >
> 
> Attached is the patch for this.
> 
> Note it is fairly similar to the previous patch - as I use
> Configuration.subset to extract the component properties and then use
> these as a "defaults" configuration for each component.

I don't see any tests? The patch looks fine but I would feel better if
you included, or added to the tests currently in place.

-- 
jvz.

Jason van Zyl
[EMAIL PROTECTED]

http://tambora.zenplex.org


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to