CP Lim <[EMAIL PROTECTED]> writes:
>Hi Henning,
>I'm using v2.2 of Turbine, and I agree that the configuration lookup is
>correct. I think the bug is in the
>o.a.t.services.pull.TurbinePullService.java file.
>The following is the extract from the file (line 223):
>---------------------
> /**
> * Property tag for per request tool refreshing
> * (for obvious reasons has no effect for per-request tools)
> */
> private static final String TOOLS_PER_REQUEST_REFRESH =
> "tools.per.request.refresh";
>---------------------
>As you can see it is using 'tools.per.request.refresh' instead of
>'services.PullService.tools.per.request.refresh', which I think is the
>core of the bug.
Either I'm too blind to understand what you consider the bug or you
don't understand how this property is evaluated. :-) Look a little
further below:
(Line numbers straight from the TURBINE_2_2_0 tag in the CVS)
265 Configuration conf = getConfiguration();
[...]
289 refreshToolsPerRequest = conf.getBoolean(TOOLS_PER_REQUEST_REFRESH);
The "conf" object fetched in line 265 is already a subset of the
global configuration. These are all objects with the
"services.PullService" prefix. This prefix is stripped from the
properties. Simply look up the definition of getConfiguration() in the
parent object. This is _not_ Turbine.getConfiguration which returns
the whole configuration properties set.
And in 289 we fetch the boolean value of the property above. So we do
check services.PullService.tools.per.request.refresh
Or am I getting it all wrong what you want?
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED] +49 9131 50 654 0 http://www.intermeta.de/
Java, perl, Solaris, Linux, xSP Consulting, Web Services
freelance consultant -- Jakarta Turbine Development -- hero for hire
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
