> Either I'm too blind to understand what you consider the bug or you > don't understand how this property is evaluated. :-)
Unfortunately I think its the latter (and a bit more). :)
I mistakenly thought that the "services.PullService.tools.per.request.refresh" was applied to _request_ level pull tools, but it turns out that it is applied to _session_ level pull tools.
It looks like for request level pull tools, if I want to refresh my objects I'll have to manually reset them in the init() method (I had previously depended on the refresh() method to be invoked).
Sorry for any inconvenience caused.
cheers, CP
Henning P. Schmiedehausen wrote:
CP Lim <[EMAIL PROTECTED]> writes:
Hi Henning,
I'm using v2.2 of Turbine, and I agree that the configuration lookup is correct. I think the bug is in the o.a.t.services.pull.TurbinePullService.java file.
The following is the extract from the file (line 223):
--------------------- /** * Property tag for per request tool refreshing * (for obvious reasons has no effect for per-request tools) */ private static final String TOOLS_PER_REQUEST_REFRESH = "tools.per.request.refresh";
---------------------
As you can see it is using 'tools.per.request.refresh' instead of 'services.PullService.tools.per.request.refresh', which I think is the core of the bug.
Either I'm too blind to understand what you consider the bug or you don't understand how this property is evaluated. :-) Look a little further below:
(Line numbers straight from the TURBINE_2_2_0 tag in the CVS)
265 Configuration conf = getConfiguration(); [...] 289 refreshToolsPerRequest = conf.getBoolean(TOOLS_PER_REQUEST_REFRESH);
The "conf" object fetched in line 265 is already a subset of the global configuration. These are all objects with the "services.PullService" prefix. This prefix is stripped from the properties. Simply look up the definition of getConfiguration() in the parent object. This is _not_ Turbine.getConfiguration which returns the whole configuration properties set.
And in 289 we fetch the boolean value of the property above. So we do check services.PullService.tools.per.request.refresh
Or am I getting it all wrong what you want?
Regards Henning
-- R E D S H E R I F F C.P. Lim - Software Engineer Level 1, 10 Queens Road +61 3 9864 0733 tel Melbourne VIC +61 3 9864 0778 fax Australia +61 413 781 846 mob
This message and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you are not the intended recipient, you are hereby notified that any use or dissemination of this communication is strictly prohibited. If you have received this message in error please notify us immediately by return email or telephone +61 (3) 9659 0432, then delete this message. Any views expressed in this message are those of the individual sender and many not necessarily reflect the views of Red Sheriff.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
