Hi Henning,
see my comments below ...
Cheers
Siegfried Goeschl
Henning P. Schmiedehausen wrote:
[EMAIL PROTECTED] writes:
+ /** the name of the subversion metadata directory */
+ private static final String SVN_DIRNAME = ".svn";
+
/////////////////////////////////////////////////////////////////////////
// Avalon Service Lifecycle Implementation
/////////////////////////////////////////////////////////////////////////
@@ -457,7 +460,9 @@
for( int i=0; i<list.length; i++ )
{
- if( list[i].isDirectory() )
+ // skip the subversion directories otherwise we pick up unexpected files
+
+ if( list[i].isDirectory() && (list[i].getName().equalsIgnoreCase(SVN_DIRNAME) == false) )
Does this make sense? As we can be quite sure that noone will ever
repeat the "CVS" mistake, why not use
list[i].isHidden()
Good point but using CVS I found out the CVS folders might be hidden or
not - it depends on the CVS tool being used. And I have no experience
with SVN on other platforms than Windows so this might be not a general
solution.
or (if this breaks on Windows) list[i].getName().charAt(0) == '.'
Using a leading "." for configuration directories seems quite common
nowadays and ignoring such directories might be a surprise for a developer.
So we will not stumble over it when the next meta directory arrives.
Having said that I'm also not happy with my SVN hack. What about adding
the isHidden() as an addition to the SVN directory check to be on the
safe side?
Regards
Henning
