Hi Angelo,
1) as far as I am concerned this is a general-purpose service .... :-)
2) the tests are not intended to work on a clean resource tree since
this problem might also occur during local development. It never
happened to me since I currently use CVS and I was also not looking for
TXT files
3) IMHO an ANT exclude/include mechanism is a little bit of overkill
since any user would expect something ANT or Maven-like such as
include=**/*.txt or exclude=**/foo/*.txt and I strive for a sensible
default behaviour. Personally I can't imagine that someone is eager to
store project files into a ".svn" directory so ignoring hidden
directories seems a more sensible approach. Having said that I'm also
concerned about the platform differerence regarding hidden directories
... maybe an exclude/include mechanism based on directory names would
suffice
Cheers,
Siegfried Goeschl
Angelo Turetta wrote:
Siegfried Goeschl wrote:
Henning P. Schmiedehausen wrote:
[EMAIL PROTECTED] writes:
+ /** the name of the subversion metadata directory */
+ private static final String SVN_DIRNAME = ".svn";
+
- if( list[i].isDirectory() )
+ // skip the subversion directories otherwise we pick
Does this make sense? As we can be quite sure that noone will ever
repeat the "CVS" mistake, why not use
list[i].isHidden()
I think this is wrong for more than this reason.
Is the fulcrum-resourcemanager intended as a general-purpose service?
So why should you have such a hack in the code? What if some user need
to keep their resource files in a directrory called .svn?
This is actually a problem in the test code itself. If the test suite
needs to work on a clean resource tree, copy the files from
src/test/resources somewhere under target, skipping everything you
don't need, then run the test pointing the repository to the clean tree.
Otherwise the only clean way of skipping a directory is by adding
configuration options like ant's "exclude/include" and let the user
specify what to consider part of their repository.
Angelo Turetta.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
