For clairity (and to avoid long lines) I often put element content onto 
separte lines because the whitespace usually gets trimmed (unless, of 
course, its in a CDATA block).  My cvsWebUrl and issueTrackingUrl elements 
look like

    <cvsWebUrl>
        http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/cli4j/cli4j-2/
    </cvsWebUrl>
    <issueTrackingUrl>
        http://sourceforge.net/tracker/?group_id=40471&amp;atid=428103
    </issueTrackingUrl>

This breaks the changelog because spaces are introduced into the final 
file urls.  Also, the navigation href's have incorrect linebreaks.

The patch simply trims any leading and trailing whitespace from the
cvsWebUrl and issueTrackingUrl elements.

Glenn McAllister
SOMA Networks, Inc.
Index: src/dvsl/xdocs/site.dvsl
===================================================================
RCS file: /home/cvs/jakarta-turbine-maven/src/dvsl/xdocs/site.dvsl,v
retrieving revision 1.29
diff -u -r1.29 site.dvsl
--- src/dvsl/xdocs/site.dvsl    24 Apr 2002 15:32:40 -0000      1.29
+++ src/dvsl/xdocs/site.dvsl    26 Apr 2002 13:14:59 -0000
@@ -154,10 +154,10 @@
                 <div><small><a 
href="$relativePath/tasks.html">Tasks</a></small></div>
                 #end
                 #if ($projectDescriptor.cvsWebUrl)
-                <div><small><a href="$projectDescriptor.cvsWebUrl">CVS 
Repository</a></small></div>
+                <div><small><a 
+href="$projectDescriptor.cvsWebUrl.toString().trim()">CVS 
+Repository</a></small></div>
                 #end
                 #if ($projectDescriptor.issueTrackingUrl)
-                <div><small><a href="$projectDescriptor.issueTrackingUrl">Issue 
Tracking</a></small></div>
+                <div><small><a 
+href="$projectDescriptor.issueTrackingUrl.toString().trim()">Issue 
+Tracking</a></small></div>
                 #end
                 <div><small><a href="$relativePath/changelog.html">Change 
Log</a></small></div>
                 #if ($context.toolbox.testSrcPresent == "true")
@@ -361,9 +361,9 @@
 #end
 
 #match("file")
-  <a href="$projectDescriptor.cvsWebUrl$node.name.value()">
+  <a href="$projectDescriptor.cvsWebUrl.toString().trim()$node.name.value()">
     $node.name.value()</a> - 
-  <a 
href="$projectDescriptor.cvsWebUrl$node.name.value()?rev=$node.revision.value()&amp;content-type=text/vnd.viewcvs-markup">

+  <a 
+href="$projectDescriptor.cvsWebUrl.toString().trim()$node.name.value()?rev=$node.revision.value()&amp;content-type=text/vnd.viewcvs-markup">
+
     v$node.revision.value()</a> <br/>
 #end
 

Reply via email to