On Sat, 27 Apr 2002, Pete Kazmier wrote: > On Fri, Apr 26, 2002 at 09:29:22AM -0400, Glenn A. McAllister wrote: > > For clairity (and to avoid long lines) I often put element content onto > > separte lines because the whitespace usually gets trimmed (unless, of > > course, its in a CDATA block). My cvsWebUrl and issueTrackingUrl elements > > look like > > > > <cvsWebUrl> > > http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/cli4j/cli4j-2/ > > </cvsWebUrl> > > <issueTrackingUrl> > > http://sourceforge.net/tracker/?group_id=40471&atid=428103 > > </issueTrackingUrl> > > > > This breaks the changelog because spaces are introduced into the final > > file urls. Also, the navigation href's have incorrect linebreaks. > > > > The patch simply trims any leading and trailing whitespace from the > > cvsWebUrl and issueTrackingUrl elements. > > I'd prefer to hold off on this patch because I believe the correct place > to "fix" this is in the Mapper itself. It seems to me that when one > calls Project.getCvsWebUrl() or Project.getIssueTrackingUrl(), the > returned string should not contain the leading/trailing whitespace. It > would be nice if the Mapper would (via an option perhaps) perform a > trim() on the element before it set()'s the appropriate property in the > object model. Jason, what do you think? >
No objection here. URL's can't have leading or trailing whitespace; embedded spaces have to be encoded. Doing it in the object is probably the best place. Glenn McAllister SOMA Networks, Inc.
