It seems BCEL only read class files ... Will need to find something else ... Regexp would probably do ... Any better idea for getting the class package name ? (note: we can't load the class as it is not in the classpath).
Apart from this I think we need to clear up maven.src.dir vs maven.src.set. The jxr task uses maven.src.set, it is thus logical that the checkstyle one would also use maven.src.set, no ? Thanks -Vincent > -----Original Message----- > From: Vincent Massol [mailto:[EMAIL PROTECTED]] > Sent: 25 May 2002 13:38 > To: 'Turbine Maven Developers List' > Subject: RE: [PATCH] Checkstyle links now working ! > > Ah ok. I thought that all the src directories were defined in the POM, > eg. : > > <sourceDirectories> > <sourceDirectory>src/java</sourceDirectory> > <sourceDirectory>src/descriptors</sourceDirectory> > <sourceDirectory>src/test</sourceDirectory> > </sourceDirectories> > > But apparently this is not true ? Any reason ? Can't we establish this > as a rule : "you need to declare you src directory structure in the POM" > ? > > There is another option but more complex, which is to find out the > directory name by introspecting the java class package (which is what > the xref code does I believe). Then we would be able to continue using > maven.src.dir and not the POM. But I'm not sure it's worth the effort. > > Anyway I find it a bit weird that we define the source directories in 2 > places : > > - once in the POM > - and another time in the maven.src.dir property > > Any reason for that ? > > In the meantime I'll explore BCEL that I have never used to see how easy > I could use it in PathUtil to find out the shortened path. > > Thanks > -Vincent > > > -----Original Message----- > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] > > Sent: 25 May 2002 13:15 > > To: Turbine Maven Developers List > > Subject: RE: [PATCH] Checkstyle links now working ! > > > > Nope, it's because the files are outside the src.set...... > > -- > > dIon Gillard, Multitask Consulting > > Work: http://www.multitask.com.au > > Developers: http://adslgateway.multitask.com.au/developers > > > > > > > > > > "Vincent Massol" <[EMAIL PROTECTED]> > > 05/25/02 09:50 PM > > Please respond to "Turbine Maven Developers List" > > > > > > To: "'Turbine Maven Developers List'" <turbine-maven- > > [EMAIL PROTECTED]> > > cc: > > Subject: RE: [PATCH] Checkstyle links now working ! > > > > > > Hum. I guess it must be because you're on unix. I'll try to run it on > > jakarta.apache.org and find why. > > > > Thanks > > -Vincent > > > > > -----Original Message----- > > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] > > > Sent: 25 May 2002 12:51 > > > To: Turbine Maven Developers List > > > Subject: RE: [PATCH] Checkstyle links now working ! > > > > > > The URLs it generates are wrong...e.g. for the line numbers, it > > generates: > > > file:/home/dion/source/jakarta-turbine- > > > maven/target/docs/xref//home/dion/source/jakarta-turbine- > > > maven/src/descriptors/SliceProject.html#34 > > > > > > And the urls for the test directory are the full directory name, not > > the > > > shortened one. > > > -- > > > dIon Gillard, Multitask Consulting > > > Work: http://www.multitask.com.au > > > Developers: http://adslgateway.multitask.com.au/developers > > > > > > > > > > > > > > > "Vincent Massol" <[EMAIL PROTECTED]> > > > 05/25/02 09:24 PM > > > Please respond to "Turbine Maven Developers List" > > > > > > > > > To: "'Turbine Maven Developers List'" <turbine-maven- > > > [EMAIL PROTECTED]> > > > cc: > > > Subject: RE: [PATCH] Checkstyle links now working ! > > > > > > > > > Hum. I have only tested it on windows and you may be running unix ? > > > Where do you get an error ? > > > > > > -Vincent > > > > > > > -----Original Message----- > > > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] > > > > Sent: 25 May 2002 12:15 > > > > To: Turbine Maven Developers List > > > > Subject: RE: [PATCH] Checkstyle links now working ! > > > > > > > > Vincent, > > > > > > > > the patches break running the reports locally on my box....I'll > see > > if > > > I > > > > can work out why later tonight... > > > > -- > > > > dIon Gillard, Multitask Consulting > > > > Work: http://www.multitask.com.au > > > > Developers: http://adslgateway.multitask.com.au/developers > > > > > > > > > > > > > > > > > > > > "Vincent Massol" <[EMAIL PROTECTED]> > > > > 05/25/02 06:17 PM > > > > Please respond to "Turbine Maven Developers List" > > > > > > > > > > > > To: "'Turbine Maven Developers List'" <turbine-maven- > > > > [EMAIL PROTECTED]> > > > > cc: > > > > Subject: RE: [PATCH] Checkstyle links now working ! > > > > > > > > > > > > Argh! Sorry. Here it is. > > > > > > > > -Vincent > > > > > > > > > -----Original Message----- > > > > > From: Pete Kazmier [mailto:[EMAIL PROTECTED]] > > > > > Sent: 25 May 2002 02:32 > > > > > To: [EMAIL PROTECTED] > > > > > Subject: Re: [PATCH] Checkstyle links now working ! > > > > > > > > > > On Sat, May 25, 2002 at 12:48:51AM +0100, Vincent Massol wrote: > > > > > > It took me a while but the checkstyle file names and line > number > > > > links > > > > > > are now working. > > > > > > > > > > Cool. > > > > > > > > > > > I also had to create a java class (PathUtil) used from within > > > > > > checkstyle.dvsl to help resolve the paths. > > > > > > > > > > Could you also send PathUtil.java class? It does not appear in > > the > > > > > patch you supplied. > > > > > > > > > > Thanks! > > > > > Pete > > > > > > > > > > > > > > > -- > > > > > To unsubscribe, e-mail: <mailto:turbine-maven-dev- > > > > > [EMAIL PROTECTED]> > > > > > For additional commands, e-mail: <mailto:turbine-maven-dev- > > > > > [EMAIL PROTECTED]> > > > > > > > > -- > > > > To unsubscribe, e-mail: <mailto:turbine-maven-dev- > > > > [EMAIL PROTECTED]> > > > > For additional commands, e-mail: <mailto:turbine-maven-dev- > > > > [EMAIL PROTECTED]> > > > > > > > > > > > > -- > > > To unsubscribe, e-mail: <mailto:turbine-maven-dev- > > > [EMAIL PROTECTED]> > > > For additional commands, e-mail: <mailto:turbine-maven-dev- > > > [EMAIL PROTECTED]> > > > > > > > > > > > > > > > > > > -- > > > To unsubscribe, e-mail: <mailto:turbine-maven-dev- > > > [EMAIL PROTECTED]> > > > For additional commands, e-mail: <mailto:turbine-maven-dev- > > > [EMAIL PROTECTED]> > > > > > > > > -- > > To unsubscribe, e-mail: <mailto:turbine-maven-dev- > > [EMAIL PROTECTED]> > > For additional commands, e-mail: <mailto:turbine-maven-dev- > > [EMAIL PROTECTED]> > > > > > > > > > > > > -- > > To unsubscribe, e-mail: <mailto:turbine-maven-dev- > > [EMAIL PROTECTED]> > > For additional commands, e-mail: <mailto:turbine-maven-dev- > > [EMAIL PROTECTED]> > > > > -- > To unsubscribe, e-mail: <mailto:turbine-maven-dev- > [EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:turbine-maven-dev- > [EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
