> -----Original Message-----
> From: Vincent Massol [mailto:[EMAIL PROTECTED]]
> Sent: 26 May 2002 09:55
> To: 'Turbine Maven Developers List'
> Subject: RE: [PATCH] checkstyle link fix (second try)
>
>
>
> > -----Original Message-----
> > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
> > Sent: 26 May 2002 03:30
> > To: Turbine Maven Developers List
> > Subject: Re: [PATCH] checkstyle link fix (second try)
> >
> > This works fine, except it still fails for classes that are not part
> of
> > the <sourceDirectories>, but are found in maven.src.dir, e.g.
> > SliceDescriptor, our entire test hierarchy etc.
> >
>
> this I don't understand ... because the checkstyle tasks uses the
> following :
>
> <fileset
> dir="${maven.src.dir}"
> includes="${maven.checkstyle.includes}"
> excludes="${maven.checkstyle.excludes}"/>
>
> thus this should take *all* files un maven.src.dir
>
> then, dvsl is used to read the checkstyle generated report xml file
> (which should then contain all files in maven.src.dir).
>
> I really don't see where it is wrong. Any idea ?
>
> > I still think we need to have properties for the sourceDirectories.
My
> > proposal is to do the following:
> > 1) Use Vincent's patch.
> > 2) Add a new ant property available: maven.sourceDirectories.fileset
> > 3) Change the checkstyle target to use that fileset rather than
> src.dir.
>
> I'm +0 because I think it should work without even the need for that
> property (unless there is something I am missing in my above
description
> - but I'd like to understand that first).
>
> I'll try it with a src/test directory that I don't put in
> <sourcedirectory> to see if it works here.
Works fine for me. I have this :
<project>
|_ src
|_ core
|_ test
and in my POM :
<build>
<sourceDirectories>
<sourceDirectory>src/core</sourceDirectory>
</sourceDirectories>
</build>
and I get checkstyle reports on my src/test classes with links.
Can you trace what's wrong on your side ?
-Vincent
>
> -Vincent
>
> >
> > +1/-1/0?
> > --
> > dIon Gillard, Multitask Consulting
> > Work: http://www.multitask.com.au
> > Developers: http://adslgateway.multitask.com.au/developers
> >
> >
> >
> >
> > "Vincent Massol" <[EMAIL PROTECTED]>
> > 05/25/02 11:27 PM
> > Please respond to "Turbine Maven Developers List"
> >
> >
> > To: <[EMAIL PROTECTED]>
> > cc:
> > Subject: [PATCH] checkstyle link fix (second try)
> >
> >
> > Here is my second patch which replaces the previous one. I am much
> > happier with this one as :
> >
> > - There is no change to ProjectProperties.java
> > - It does not depend on maven.src.dir nor maven.src.set
> >
> > FYI, it uses JDepend to find the location of the source file :
> >
> > public static final String getPackagePath(String
absoluteFileName)
> > throws IOException
> > {
> > JavaSourceFileParser parser = new JavaSourceFileParser();
> > JavaClass clazz = parser.parse(absoluteFileName);
> > String packageName = clazz.getPackageName();
> >
> > return packageName.replace('.', File.separatorChar) +
> > File.separatorChar + clazz.getName() + ".java";
> > }
> >
> > JDepend looks cool and useful :-)
> >
> > -Vincent
> >
> > PS: I haven't tried it on unix.
> > --
> > To unsubscribe, e-mail: <mailto:turbine-maven-dev-
> > [EMAIL PROTECTED]>
> > For additional commands, e-mail: <mailto:turbine-maven-dev-
> > [EMAIL PROTECTED]>
>
>
>
> --
> To unsubscribe, e-mail: <mailto:turbine-maven-dev-
> [EMAIL PROTECTED]>
> For additional commands, e-mail: <mailto:turbine-maven-dev-
> [EMAIL PROTECTED]>
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
