> -----Original Message-----
> From: Martin van den Bemt [mailto:[EMAIL PROTECTED]]
> Sent: 26 May 2002 12:12
> To: Turbine Maven Developers List
> Subject: Re: [PATCH] checkstyle link fix (second try)
>
> I didn't get the complete discussion, so probably my assumption is
wrong
> that I have of the statement below..
> As long as all sourceDirectories always can be retrieved from the
> project.xml, I will be ok with this, otherwise I am going to have
major
> problems with simple integration in IDE's..
> I don't want to depend on some properties set somewhere to figure out
> where the source could be, if you know what I mean :)
then we agree ... :-) However, ATM there are lots of maven properties
that are defined in maven default properties file and that users can
override in their project.properties file (for example: maven.src.dir).
>
> Mvgr,
> Martin
>
>
> On Sun, 2002-05-26 at 04:30, [EMAIL PROTECTED] wrote:
> > This works fine, except it still fails for classes that are not part
of
> > the <sourceDirectories>, but are found in maven.src.dir, e.g.
> > SliceDescriptor, our entire test hierarchy etc.
> >
> > I still think we need to have properties for the sourceDirectories.
My
> > proposal is to do the following:
> > 1) Use Vincent's patch.
> > 2) Add a new ant property available: maven.sourceDirectories.fileset
> > 3) Change the checkstyle target to use that fileset rather than
src.dir.
> >
> > +1/-1/0?
> > --
> > dIon Gillard, Multitask Consulting
> > Work: http://www.multitask.com.au
> > Developers: http://adslgateway.multitask.com.au/developers
> >
> >
> >
> >
> > "Vincent Massol" <[EMAIL PROTECTED]>
> > 05/25/02 11:27 PM
> > Please respond to "Turbine Maven Developers List"
> >
> >
> > To: <[EMAIL PROTECTED]>
> > cc:
> > Subject: [PATCH] checkstyle link fix (second try)
> >
> >
> > Here is my second patch which replaces the previous one. I am much
> > happier with this one as :
> >
> > - There is no change to ProjectProperties.java
> > - It does not depend on maven.src.dir nor maven.src.set
> >
> > FYI, it uses JDepend to find the location of the source file :
> >
> > public static final String getPackagePath(String
absoluteFileName)
> > throws IOException
> > {
> > JavaSourceFileParser parser = new JavaSourceFileParser();
> > JavaClass clazz = parser.parse(absoluteFileName);
> > String packageName = clazz.getPackageName();
> >
> > return packageName.replace('.', File.separatorChar) +
> > File.separatorChar + clazz.getName() + ".java";
> > }
> >
> > JDepend looks cool and useful :-)
> >
> > -Vincent
> >
> > PS: I haven't tried it on unix.
> > --
> > To unsubscribe, e-mail: <mailto:turbine-maven-dev-
> [EMAIL PROTECTED]>
> > For additional commands, e-mail: <mailto:turbine-maven-dev-
> [EMAIL PROTECTED]>
> >
> > ----
> >
>
> > --
> > To unsubscribe, e-mail: <mailto:turbine-maven-dev-
> [EMAIL PROTECTED]>
> > For additional commands, e-mail: <mailto:turbine-maven-dev-
> [EMAIL PROTECTED]>
>
>
>
> --
> To unsubscribe, e-mail: <mailto:turbine-maven-dev-
> [EMAIL PROTECTED]>
> For additional commands, e-mail: <mailto:turbine-maven-dev-
> [EMAIL PROTECTED]>
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
