Hi,
A little while ago, I submitted a first attempt at the JRefactory / Checksource
integration that I picked up from the musings document. Before completing the
code I wanted some feedback on the work I'd done. I did this mainly because I
wanted to make sure the new code & changes I was suggesting were sensible before
spending more time on the work.
I'm keen to get this finished as I'd like to start work on the JDiff integration.
I've listed below the key points of the work done so far. I'd appreciate some
pointers on any of the below e.g. good / bad idea, bad names, inappropriate
directories etc.
There is a set of properties that form the maven source definition with the
prefix maven.sourcedef. These properties are the intersection of the checkstyle
and JRefactory properties. These properties are placed in default.properties
All properties unique to checkstyle or jrefactory keep their original property
names. This is due to the large number of configurable properties compared to
the relatively small number of properties common to the two tools.
JRefactory requires a file in the {user.home}/.Refactory/pretty.settings
containing the configuration for the pretty printer. This file is
auto-generated by the new maven JRefactory task from the combination of settings
from a jrefactory config file and the maven.sourcedef settings. This default
file is placed in {maven.home}/pretty.settings.
For consistency, the checkstyle settings are moved from maven.checkstyle.xyz in
default.properties, returned to their original property names and placed into
their own property file {maven.home}/checkstyle.settings.
A new package org.apache.maven.sourcedef. Contains two new tasks that extend
the checkstyle and jrefactory tasks. These tasks override some of the original
properties with the values from the maven source definition. This guarantees
that JRefactory will generate code that passes checkstyle tests. package also
contains a utility class for providing access to the maven.sourcedef properties
& default values.
Would it make sense to place the checkstyle and the jrefactory tasks in their
own /plugins/checkstyle and plugins/jrefactory directories?
Cheers
Nathan
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
