On Mon, May 27, 2002 at 03:52:01PM +0100, Nathan Coast wrote: > There is a set of properties that form the maven source definition > with the prefix maven.sourcedef. These properties are the > intersection of the checkstyle and JRefactory properties. These > properties are placed in default.properties All properties unique to > checkstyle or jrefactory keep their original property names. This is > due to the large number of configurable properties compared to the > relatively small number of properties common to the two tools.
Please be sure to document the properties in xdocs/ref/properties.xml document as well. Perhaps hold off on that until we see your patch. > A new package org.apache.maven.sourcedef. Contains two new tasks that > extend the checkstyle and jrefactory tasks. These tasks override some > of the original properties with the values from the maven source > definition. This guarantees that JRefactory will generate code that > passes checkstyle tests. package also contains a utility class for > providing access to the maven.sourcedef properties & default values. Hmmm ... rather than extending the checkstyle and jrefactory tasks, would it be better to have an Ant task that just generates the two property files at runtime? I.e. this Ant task reads the common source policy properties (from default.properties unless overriden by user of course), and then generates the appropriate property files specific to checkstyle and jrefactory? I normally don't like extending classes across package boundaries especially when we don't control the source. > Would it make sense to place the checkstyle and the jrefactory tasks > in their own /plugins/checkstyle and plugins/jrefactory directories? No. I think the files should be generated at run-time and stored in the project's directory (in one of the directories that is created by Maven when building the source). What do you think? Thanks, Pete -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
