> patch applied. Very cool. The synchronized addition looks good.
One minor thing, the 2nd managers.get can be put inside the if (m == null) bit so that it's only done when needed and avoids looking it up twice if the manager is successfully found the first time. Index: Torque.java =================================================================== RCS file: /home/cvspublic/jakarta-turbine-torque/src/java/org/apache/torque/Torque .java,v retrieving revision 1.62 diff -r1.62 Torque.java 634d633 < } 636,637c635,637 < // Try again now that the default manager should be in the map < m = (AbstractBaseManager) managers.get(name); --- > // Try again now that the default manager should be in the map > m = (AbstractBaseManager) managers.get(name); > } (Btw, is putting short patches like the one above in email okay? I had thought line wrapping was an issue so had gotten in the habit of sending in txt files). Thanks, Stephen -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
