Issue 'TRQ31' has just been modified by user 'drfish'

You can view the issue detail at the following URL:
     <http://scarab.werken.com/issues/id/TRQ31>

The following modifications were made to this issue:

>The parts of the patch that add I,S,D identifiers is good.
>It looks like you are wanting to change the String representation of the following key
>[NumberKey=null, StringKey=A, DateKey=null] 
>from  :A:   to   :SA::
>is the change of adding an ending colon required or you just prefer it? 

The ending colon makes the parsing/looping work the way the original author seemed to 
intend - 
ie when indexOf(:) = -1, you are done. I also find it more consistent that each 
element is terminated with the same character.
I would also note that as I am looking at it, it is
[null, StringKey="A",null] = :SA::
[NumberKey=null, StringKey="A", DateKey=null] = N:SA:D:

There is one ambiguity I can think of - a StringKey that is null vs empty (Numbers, 
nor Dates, can be "empty", just a value or null)

I will reassert that the Key types should really not have no-arg ctors nor setValue 
methods - in my experience it is bad magic to have PK's that change! 

I also think that (null) vs Key(null) is irrelevant - null is null in the database. No 
database I have worked with has a concept of a null number vs null string etc  




--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to