Issue 'TRQ31' has just been modified by user 'drfish'

You can view the issue detail at the following URL:
     <http://scarab.werken.com/issues/id/TRQ31>

The following modifications were made to this issue:

>You have setValue(String[]) assigning all keys as StringKey?  If you have the key 
>which needs >to be one of each type [NumberKey, StringKey, DateKey] and you pass it 
>["1", "A", >"938473984271923"], the ComboKey will be incorrect for the object.  Why 
>do you want to do >this?

I actually wanted to remove this method due to its ambiguity, but left it as it was 
already there, and there could concevably be an all string key, reconstituted by a 
string array. I would suggest this method would nto be for non-string types - take 
your example ["1", "A","938473984271923"], 
is it String("1"), String("A"), String("938473984271923") or is it int(1), 
String("A"), BigDecimal(938473984271923).

I must assert that this method is too ambiguous and should be removed. I can think of 
no valid reason to keep this set method (actually, I think ALL set methods should be 
removed, and Key types should be immutable. If you REALLY want to change the value, 
create a new key.)

If you want to use the above string array example, you should do 
new ComboKey(new SimpleKey[]{new NumberKey(1), new StringKey("A"), new NumberKey( 
"938473984271923")}

You can even pass the strings to the NumberKey ctor as it does accept strings.
  




--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to