On 12/8/01 2:07 AM, "Kelvin Tan" <[EMAIL PROTECTED]> wrote:
Kelvin,
Can you send me the patch as an attachment please.
>
>>>>
>>>> Send the patch and I'll apply it :-)
>>>
>>> Sure thing. Should I deprecate shutdownClass in ServiceBroker and
>>> BaseServiceBroker as well (since it's now handled by shutdownService)?
>>
>> I don't think your changes should interfere with anything and Fulcrum is
> not
>> released so you don't have to deprecate anything.
>>
>
> Here it is. I didn't remove shutdownClass in ServiceBroker though, but it's
> basically not in use anymore.
>
> Index: src/core/java/org/apache/fulcrum/BaseServiceBroker.java
> ===================================================================
> RCS file:
> /home/cvspublic/jakarta-turbine-fulcrum/src/core/java/org/apache/fulcrum/Bas
> eServiceBroker.java,v
> retrieving revision 1.10
> diff -r1.10 BaseServiceBroker.java
> 566,568c566
> < String className = (String) mapping.get(name);
> <
> < if (className != null)
> ---
>> try
> 570c568,581
> < shutdownClass(className);
> ---
>> Service service = getServiceInstance(name);
>> if (service.isInitialized())
>> {
>> service.shutdown();
>> ((BaseService) service).setInit(false);
>> }
>> }
>> catch (InstantiationException e)
>> {
>> // Shutdown of a nonexistent class was requested.
>> // This does not hurt anything, so we log the error and
> continue.
>> error(new ServiceException(
>> "Shutdown of a nonexistent service " + name +
>> " was requested", e));
>
>
>
> --
> To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
--
jvz.
Jason van Zyl
http://tambora.zenplex.org
http://jakarta.apache.org/turbine
http://jakarta.apache.org/velocity
http://jakarta.apache.org/alexandria
http://jakarta.apache.org/commons
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
