On Tue, Jul 08, 2036 at 08:20:45PM -0500, Jeff Brekke wrote:
> I have a patch for the database pooling stuff. It is on
>
> http://sites.netscape.com/ekkerbj/patches/pool.patch
I'll throw in my +1
I looked over this and it looked fine to me. I think it's definitely
right to have the driver names just in the properties file and to take
those statics out of DB.
Unfortunately I'm using MySQL so although I'll make sure it works for
me, that won't extend your testing range.
[[
As an aside I noticed that there's some formatting cleanups in there
too. Although these do improve the code's readability, my opinion is
that they shouldn't be mixed with real code changes as it made it
difficult for me to pick out your real changes, the same problem someone
looking at the CVS diff to see what you changed will have if the need
arises.
An ex-colleague of mine Tony Finch wrote some good CVS guidelines that
include this point: <http://www.apache.org/~fanf/cvs-guidelines.html>.
Perhaps formatting cleanups should only be done as a standalone
patch/commit? (This is very much just my personal opinion, I don't know
if anyone else agrees?)
]]
--
Sean Legassick
[EMAIL PROTECTED]
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
