> On Tue, Jul 08, 2036 at 08:20:45PM -0500, Jeff Brekke wrote:
> > I have a patch for the database pooling stuff. It is on
> >
> > http://sites.netscape.com/ekkerbj/patches/pool.patch
>
> I'll throw in my +1
>
+1 from me, too.
> I looked over this and it looked fine to me. I think it's definitely
> right to have the driver names just in the properties file and to take
> those statics out of DB.
>
I wholeheartedly agree. This will make adding support for new databases _much_
easier.
> Unfortunately I'm using MySQL so although I'll make sure it works for
> me, that won't extend your testing range.
>
I can test it on Oracle, InstantDB, and Hypersonic SQL (look for support coming
soon!).
> [[
> As an aside I noticed that there's some formatting cleanups in there
> too. Although these do improve the code's readability, my opinion is
> that they shouldn't be mixed with real code changes as it made it
> difficult for me to pick out your real changes, the same problem someone
> looking at the CVS diff to see what you changed will have if the need
> arises.
>
> An ex-colleague of mine Tony Finch wrote some good CVS guidelines that
> include this point: <http://www.apache.org/~fanf/cvs-guidelines.html>.
>
Thanks for pointing out this document. I'm slowly (but surely!) converting to
CVS for our in-house source control, and this will be great for bringing my
fellow employees up to speed on CVS etiquette.
> Perhaps formatting cleanups should only be done as a standalone
> patch/commit? (This is very much just my personal opinion, I don't know
> if anyone else agrees?)
+1 Also, they should be few, infrequent, and only when absolutely necessary
(e.g., ^M^M). To quote the above guidelines document:
"No-one's favourite coding style is significantly better or worse than anyone
else's so reformatting code provides no advantage to oppose the disadvantages."
However, keep in mind that Jon will probably always fix your code if you use
tabs instead of spaces. ;-)
> ]]
>
> --
> Sean Legassick
> [EMAIL PROTECTED]
>
--
Christopher Elkins
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
