> Hi.
>
> It's probably useless (?) patch, but I've decided to post it anyway :)
> It does not modify, extend or improve any functionality, but simply
> cleans things out - by replacing those ugly hard-coded string literals
> with private static constants. Feel free to ingnore it, whoever is
> responsible for commiting stuff like this :):)
>
Thanks for the patch. (I personally think removing hard-coded strings is a very
good thing.) However, your patch has diffs for lines that didn't really change.
Can you clean it up and re-submit?

> Bye.
>
> Scooter
>

Examples of what I'm talking about:
> - * it needs to do the job directly from the data.getParameters().
> + * it needs to do the job directly from the data.getParameters().
>
> -     * the RunData Parameter.
> +     * the RunData Parameter.
>
> -       data.getParameters().add("template",v);
> +       data.getParameters().add("template",v);

--
Christopher Elkins



------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?:           [EMAIL PROTECTED]

Reply via email to