Rafal,

I've tested your upload diff/changes and all are working great.  A few
comments:

*) There is a dependency on jsdk2.2 in there that is busting the build with
the older jsdk

src/org/apache/turbine/services/resources/TurbineResources.java:501: Method
getContextPath() not found in interface
javax.servlet.http.HttpServletRequest.
        url.append(req.getContextPath());

*) Unless there is some additional functionality in FileHandler/ORielly's
uploaders, maybe we should just remove them and go with this default.

   or 

Merge any functionality into the TurbineUploader

   or

Change the implementation slightly in FileHandler/OReilly to behave correctly
( populating the file list in the parameters, filenaming, memory cacheing )
and set the uploader class to use in the TR.properties.

It is confusing ( especially to the new user ) to have three uploaders, one
which is the default with one behavior, another with a different behavior,
etc.  I'm not seeing any realy benefit to the multiple implementations in this
area ( file uploading ).

I have not attempted testing multiple file uploads, but will today.
Good work!

jb

Jeff Brekke
mailto:[EMAIL PROTECTED]
http://sites.netscape.net/ekkerbj


____________________________________________________________________
Get your own FREE, personal Netscape WebMail account today at 
http://home.netscape.com/webmail


------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?:           [EMAIL PROTECTED]

Reply via email to