> What about declaring the packages Vector as a static member.
> This way we
> only build list of packages the first time and never again.
> Something like
> this
>
> static private Vector packages = null;
> ....
> if (packages == null)
> {
> Vector packages =
> TurbineResources.getVector("module.packages");
> ObjectUtils.addOnce( packages,
> GenericLoader.getBasePackage() );
> }
Careful with MT issues here! For this to work, it would
be best if packages were a Singleton or part of one.
> I think we should stick with the addOnce to check if the user
> has maybe
> added the basePackage to the properties file manually. This
> will ensure
> that org.apache.turbine.modules does not get added a second
> time if the user
> adds it in TR.properties.
Other than the MT thing, and if no other functionality is
compromised, this seems a good solution to me. I will let
the original authors examine these suggestions, as well as
my changes, and decide what is the best fix.
--
Gonzalo A. Diethelm
[EMAIL PROTECTED]
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
