Florent Aide wrote:
> I would like to propose something for our coding standards: I would
> like to ban "import *" from our code and impose the use of explicit
> import everywhere.
> This will greatly enhance readability and maintenability in the long run.
> 
> Any suggestions?

Good idea. Some of them seem to be even completely unnecessary, such as
"from turbojson.jsonify import *" in saprovider.py.

One special case are the imports from sqlobject, sqlalchemy and elixir
in model.py. In this case, importing * makes some sense. This had been
changed recently for sqlalchemy, but with a very arbitrary list, so I
changed this back to import * from sqlalchemy. I am not against
importing explicitly, but then we should do it in all 3 cases and choose
a reasonable list of names (see ticket #1604, options 2 or 3).

And as Christopher Arndt said, we should also make use of __all__.

-- Chris

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"TurboGears Trunk" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/turbogears-trunk?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to