Christoph Zwerschke schrieb:
> One special case are the imports from sqlobject, sqlalchemy and elixir
> in model.py. In this case, importing * makes some sense. This had been
> changed recently for sqlalchemy, but with a very arbitrary list, so I
> changed this back to import * from sqlalchemy. I am not against
> importing explicitly, but then we should do it in all 3 cases and choose
> a reasonable list of names (see ticket #1604, options 2 or 3).

In this case, I like option 2 (importing only the names used) better.
Otherwise we end up with huge sections of import statements at the start
of each file, which makes the code hard to scan. Admitted, it is
difficult to keep this list up-to-date (i.e. forgetting to remove unused
symbols form the import statement), but that's what pychecker is for IMHO.

Maintaining readability is also the main arguments against "from foo
import *" IMO.


Chris


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"TurboGears Trunk" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/turbogears-trunk?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to