Look, it was my choice to make this happen, and I stand by it. We can tell people installing pages to update websetup.py as nessisary, and the people reading the python magazine article can use code that just works.
And from my perspective the code inside the quickstart--that we intend for people to use and modify is part of our features, and this as a new feature should have been covered by the feature freeze. All this talk about API changes, public API changes, etc is besides the point. This is a new feature, and so should be covered by the feature freeze. But I take responsibility, this whole thing is my fault, because I told Chris to go ahead without thinking through the consequences. I made a mistake, and I totally take responsibility for that. I think the sky will not fall either way, and I am definitely one of the ones who wanted the functionality, but I also want the python magazine article to give people a positive view of TG2. Either choice was going to cause some people problems, and solve other problems, so we were never going to have everybody happy, heck we were never going to make me happy, because I want two conflicting things ;) So, with all that said, let's not fight about what constitutes and API change, and let's throw any stones than need throwing my direction. I'm a pretty good catch, and if not I can take it. Thanks! On Mon, Mar 23, 2009 at 10:52 PM, Jorge Vargas <[email protected]> wrote: > > This has taken way too long and it's way out of topic. I won't bother > answering inline anymore. If you want to think it's api change then > fine go ahead this is no api at all as you don't even need quickstart > to have a TG2 project. If you keep insisting it changes the API fine I > won't argue about that. > > In the meanwhile we have a broken tgext.pages (see the thread from > GSOC for the first user figuring that out) > > But don't worry when people complain about how inflexible websetup is > we'll point them to this thread. > > On Mon, Mar 23, 2009 at 2:21 PM, Gustavo Narea <[email protected]> wrote: >> And apologies, I slipped in that part while trying to trim the email. >> >> My thoughts on your proposal: >> 1.- It'd still be an API change, it just happens to be smaller: no new >> modules, but two new functions. > > whatever, you are making a huge deal out of splitting a function into > 3 logical functions which by the way everyone already does. > >> 2.- It'd still outdate some texts, like mine where I say something like "Add >> the contents of Listing N right before DBSession.flush() and commit()". >> > which are probably way unflexible, and again it's totally fixable. > > 15 def setup_app(command, conf, vars): > 16 """Place any commands to setup {{package}} here""" > 17 load_environment(conf.global_conf, conf.local_conf) > 18 setup_schema(command, conf, vars) > 19 bootstrap(command, conf, vars) > 20 DBSession.flush() > 21 transaction.commit() > > > > -- Mark Ramm-Christensen email: mark at compoundthinking dot com blog: www.compoundthinking.com/blog --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "TurboGears Trunk" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/turbogears-trunk?hl=en -~----------~----~----~----~------~----~------~--~---
