Am 30.07.2011 00:49 schrieb Alessandro Molina:
> There is bunch of tests to check that it works as expected but I
> still have to document it. If it is approved as is, I'll close the
> related ticket and write documentation.
Thanks, that's basically what I had in mind. Some small issues:
- I would not make these silent replacements of the method and doctype,
e.g. method html5 -> html, or doctype xhtml -> xhtml-transitional.
Since the config settings have "genshi" in their names, they should
behave like the Genshi settings, without such alterations. I.e. the
method html5 should give an error, doctype xhtml should be strict.
- If the doctype is missing, you set it from templating.genshi.method
instead of templating.genshi.doctype. Also, you assume an xhtml
doctype as defualt. I would rather try to derive it from the
already calculated value for the serialization method. html and xhtml
methods should give html and xhtml doctypes, all other methods should
not set any doctype.
- If the response.content_type is application/xhtml+xml, you set the
serialization method to xml, it should be xhtml here. Genshi has
a special XHTMLSerializer.
- If the response.content_type is application/xhtml+xml, you set the
doctype to xhtml. You should only do this if the doctype is not
compliant already, i.e. not in the case that it is xhtml11.
- Maybe we should support a response.doctype attribute with which you
can override the templating.genshi.doctype setting explicitely.
- The now meaningless comment on the pylons ticket should be removed.
If you agree I can also work out these changes and adapt tests in the
dev branch.
-- Christoph
--
You received this message because you are subscribed to the Google Groups
"TurboGears Trunk" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/turbogears-trunk?hl=en.
