On Sat, Jul 30, 2011 at 11:39 AM, Christoph Zwerschke <[email protected]> wrote: > Am 30.07.2011 00:49 schrieb Alessandro Molina: >> There is bunch of tests to check that it works as expected but I >> still have to document it. If it is approved as is, I'll close the >> related ticket and write documentation. > > Thanks, that's basically what I had in mind. Some small issues: > > - I would not make these silent replacements of the method and doctype, > e.g. method html5 -> html, or doctype xhtml -> xhtml-transitional. > Since the config settings have "genshi" in their names, they should > behave like the Genshi settings, without such alterations. I.e. the > method html5 should give an error, doctype xhtml should be strict. >
Uhm, I agree that it is good to also have the doctype config option, but I would like to avoid being forced to set both. I would really prefer being able to set the doctype and method with only one command. As doctype is actually strictly related to the rendering method (it doesn't make a lot of sense setting doctype to xhtml-strict and rendering to html) we should probably let doctype also enforce the rendering method if no rendering method is declared. This way we would have both the doctype and method config options while making possible to just set the doctype to enforce both. At this point default doctype should probably be xhtml-transitional until we decide to switch to html5. > - Maybe we should support a response.doctype attribute with which you > can override the templating.genshi.doctype setting explicitely. > Probably changing doctype/method from the content_type is already more than what is needed by most of the turbogears users, so for now I would avoid adding more complexity. We can create a separate ticket for that to keep track of the idea if we want to add it later. > If you agree I can also work out these changes and adapt tests in the dev > branch. > Yes, feel free to do that :) I'll try to implement your suggestions during the end of the week if you didn't have time to do it yourself. -- You received this message because you are subscribed to the Google Groups "TurboGears Trunk" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/turbogears-trunk?hl=en.
