Jeff Watkins wrote:

I just committed the code for the TurboGears identity management support...


Looks good!

Thanks for all your hard work on this.

Some of the things I still have to add:


Can I suggest that you change the model to use a PackageHub instead of an AutoConnectHub to allow the identity data to be sourced from a different db if required?

Also, in an attempt to minimise support questions in the future :-), it might be worth adding support for query strings to the login() function of the controller described in the How-To i.e. something like:

    def login( self, *args, **kw ):
        if hasattr(cherrypy.request,"identity_exception"):
            msg= str(cherrypy.request.identity_exception)
        else:
            msg= "Please log in"
        cherrypy.response.status=403
        prevURL = cherrypy.request.path
if cherrypy.request.queryString is not None and len(cherrypy.request.queryString) > 0:
            prevURL = '%s?%s' % (prevURL, cherrypy.request.queryString)
        return dict( message=msg, previous_url=prevURL )


Robert

Reply via email to