On 11/13/06, Bob Ippolito <[EMAIL PROTECTED]> wrote:
> The only real comment I have is that the $(...) stuff is superfluous,
> and could easily be confused with Kid's ${}. You almost never need to
> use $() unless you're directly screwing with the DOM. Everything that
> takes DOM objects should take a string identifier, and connect is no
> exception.

Good point. I had put it in in the event that people were familiar
with the convention from other javascript frameworks. Out it goes.

> Also, "e.preventDefault()" is probably better said as "e.stop()".
> Normally when you do preventDefault you also want stopPropagation, and
> that's what stop does. Though it shouldn't make a difference in this
> case.

For onclick replacement handlers I usually don't stop propagation in
case something further up the chain wants to do something with the
event.

--~--~---------~--~----~------------~-------~--~----~
 You received this message because you are subscribed to the Google Groups 
"TurboGears" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/turbogears?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to