[ please Cc: me on replies ]

Heya, I'm packaging TG2 for Debian [1].

As a minor nitpick, I've noticed that quickstart outputs a dependency
on Catwalk even if auth support has not been requested by the
user. Out of sync with that, Catwalk is actually used in the generated
code only if auth support has been requested.

The simple attached patch fix this incoherency by avoiding output the
dependency if auth support is not requested. Can you please consider
merging it? The "live" version of the patch is available at [2].

BTW, given that auth support implies more dep in the generated egg,
I've also changed the default of auth support to "no" in the Debian
package, any strong reason for having that default to "yes"? It was
that way in TG1.

TIA,
Cheers.

[1] http://upsilon.cc/~zack/tags/turbogears/
[2] 
http://svn.debian.org/viewsvn/python-modules/packages/tg.devtools/trunk/debian/patches/avoid-catwalk-dep.dpatch

-- 
Stefano Zacchiroli -o- PhD in Computer Science \ PostDoc @ Univ. Paris 7
z...@{upsilon.cc,pps.jussieu.fr,debian.org} -<>- http://upsilon.cc/zack/
Dietro un grande uomo c'è ..|  .  |. Et ne m'en veux pas si je te tutoie
sempre uno zaino ...........| ..: |.... Je dis tu à tous ceux que j'aime
#! /bin/sh /usr/share/dpatch/dpatch-run
## avoid-catwalk-dep.dpatch by Stefano Zacchiroli <[email protected]>
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: Fix to avoid declaring a useless dep on Catwalk, if auth
## DP: support has not been requested on a given project.

@DPATCH@
diff -urNad trunk~/devtools/templates/turbogears/setup.py_tmpl 
trunk/devtools/templates/turbogears/setup.py_tmpl
--- trunk~/devtools/templates/turbogears/setup.py_tmpl  2009-03-16 
23:57:55.000000000 +0100
+++ trunk/devtools/templates/turbogears/setup.py_tmpl   2009-06-21 
13:26:40.663854382 +0200
@@ -15,7 +15,9 @@
     #url='',
     install_requires=[
         "TurboGears2 >= 2.0b7",
+        {{if auth == "sqlalchemy"}}
         "Catwalk >= 2.0.2",
+        {{endif}}
         "Babel >=0.9.4",
         {{if sqlalchemy}}
         "zope.sqlalchemy >= 0.4 ",

Attachment: signature.asc
Description: Digital signature

Reply via email to