Hello Zack or Stefano :p On Mon, Jun 22, 2009 at 5:52 AM, Stefano Zacchiroli<[email protected]> wrote: > [ please Cc: me on replies ] > > Heya, I'm packaging TG2 for Debian [1]. > awesome looking forward for that one. Lets see if it's out before luke's RPMs :)
> As a minor nitpick, I've noticed that quickstart outputs a dependency > on Catwalk even if auth support has not been requested by the > user. Out of sync with that, Catwalk is actually used in the generated > code only if auth support has been requested. > > The simple attached patch fix this incoherency by avoiding output the > dependency if auth support is not requested. Can you please consider > merging it? The "live" version of the patch is available at [2]. > This is indeed correct, In fact if you saw allow_only = None it will work but that's encouraging security issues which we don't want. So yes your patch should go in. I'll make sure it's applied next saturday on our bugfix day. > BTW, given that auth support implies more dep in the generated egg, > I've also changed the default of auth support to "no" in the Debian > package, any strong reason for having that default to "yes"? It was > that way in TG1. > This is something I don't like at all. In fact in TG1 we consider that default to be one of the bad decisions. So I really encourage you to make auth = yes by default because this is what the quickstart sets as default. In TG2 we want to let people know up front this that this is not a toy framework and defaults reallly matter for this. > TIA, > Cheers. > > [1] http://upsilon.cc/~zack/tags/turbogears/ > [2] > http://svn.debian.org/viewsvn/python-modules/packages/tg.devtools/trunk/debian/patches/avoid-catwalk-dep.dpatch > > -- > Stefano Zacchiroli -o- PhD in Computer Science \ PostDoc @ Univ. Paris 7 > z...@{upsilon.cc,pps.jussieu.fr,debian.org} -<>- http://upsilon.cc/zack/ > Dietro un grande uomo c'è ..| . |. Et ne m'en veux pas si je te tutoie > sempre uno zaino ...........| ..: |.... Je dis tu à tous ceux que j'aime > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > > iD8DBQFKP1R11cqbBPLEI7wRAs9JAKC85X+UaQLbj8lNoMwSSH+fJu8pHwCfYP65 > FWS5XW7VibszFXRHlgrDzXA= > =ZLlp > -----END PGP SIGNATURE----- > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "TurboGears" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/turbogears?hl=en -~----------~----~----~----~------~----~------~--~---
