On 4/1/11, Jannico <[email protected]> wrote:
> Dear Turbogears-1.5 friends,
>
> here are the first two things I found while updating from 1.0.9 to
> 1.5.b2
>
> (1) config.py seems to have a small bug in update(), starting in line
> 289
>
>         elif key in server_sections and isinstance(value, dict):
>             server.update(value)
>             for key in valu:
>                 key = _check_name(key)
>                 if key:
>                     server[key] = value
>
> should, I think, better read
>
>         elif key in server_sections and isinstance(value, dict):
>             server.update(value)
>             for key,val in value.items():
>                 key = _check_name(key)
>                 if key:
>                     server[key] = val
>
> or some keys out of the dictionary (if re-written by _check_name)
> receive the complete dictionary as value ... which is not always what
> you would want to have ;)

I had a very similar issue but was not able to track down the reason.
Now I think you spotted the reason for my problem as well. I reported
this here:

http://groups.google.com/group/turbogears/browse_thread/thread/74985722e321fbca/4121df062d5df517

but since didn't have much time lately I couldn't follow up on Chris'
further questions.

Thanks a lot!

Cheers,
Daniel


> (2) Imagine the following situation:
> - You define some meaningful "semantic" exception classes and
> appropriate handlers (for example to send some specific JSON output to
> the client if the exception is raised) in your application, for
> example AppException and app_exception_handler.
>
> - You then decorate some of your controllers:
> @exception_handler(app_exception_handler, "isinstance(tg_exceptions,
> AppException)")
>
> This works in TG1.0.9. It does not work anymore in 1.5 (seemingly
> because the compile/preprocessing step of the PEAKrules rule
> processing does not know anything about AppException). Using a fully
> qualified name, like yourapplication. ... .AppException does not work
> either (as yourapplication is also not known inside the rules
> proprocessing)
>
> Well, it is possible to work around it (simply leave out the rule part
> and decide about the treatment of different exceptions in the handler,
> perhaps re-raising "unknown" exceptions to be catched somewhere else).
> But perhaps, it is also possible to give the rules preprocessing
> access to some of the app specific names? (I will stick with the less
> complex and easily manageable work around anyway, just a not-too-
> important question for your kind consideration).
>
> By the way: I am confident that finally, everything will run smoothly
> again (well, we extended the visit manager, we used the"old" file
> upload filter, etc., so it took me some time to get the server running
> (not yet "working"...see above), but I really value all the effort
> that has been put into TurboGears and all the components glued
> together, especially, of course, CherryPy - thanks for keeping the 1.5
> branch alive ;)
>
> Jannico
>
> (If it is better to post potential bugs to some other place, just let
> me know)
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "TurboGears" group.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to
> [email protected].
> For more options, visit this group at
> http://groups.google.com/group/turbogears?hl=en.
>
>


-- 
Psss, psss, put it down! - http://www.cafepress.com/putitdown

-- 
You received this message because you are subscribed to the Google Groups 
"TurboGears" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/turbogears?hl=en.

Reply via email to