Jim, I think the problem may be that AFAIR it has never been made clear on
the mailing list that "mvn -Psourcecheck" is a required or exactly what it
does or how it works. I can find several mails about doing it and problems
with doing it, but nothing saying something like 'this is the proposal, is
everyone ok with making it mandatory".

  ...ant

On 8/5/06, Jim Marino <[EMAIL PROTECTED]> wrote:

At the risk of throwing stones in a glass house (since I forget to
set svn ignore), *please* remember to run mvn -Psourcecheck prior to
checkins for Java SCA. The Checkstyle audit raises a significant
number of formatting errors that are trivial to avoid by setting
templates in an IDE.

More importantly, PMD fails the build, which is generally a sign of a
potential problem in code. For example,  JavaLoggingMonitorFactory
fails with a PMD violation. In this case, it's because the
constructor calls out to an overridable method, which is a bad thing.

There are various areas of the build that are in a state of
disrepair. Can people please clean these up as soon as possible?

Jim

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Reply via email to