On Aug 6, 2006, at 3:25 AM, ant elder wrote:
Jim, I think the problem may be that AFAIR it has never been made
clear on
the mailing list that "mvn -Psourcecheck" is a required or exactly
what it
does or how it works. I can find several mails about doing it and
problems
with doing it, but nothing saying something like 'this is the
proposal, is
everyone ok with making it mandatory".
There was a somewhat lengthy discussion and then what I and others
thought was agreement. As I recall, you originally objected and then
after more discussion, I asked if you still had objections and
received no response so assumed you were o.k. with it.
Dan provided a detailed overview of what it is:
http://www.mail-archive.com/[email protected]/msg01998.html
There was some discussion, Jeremy and you had some issues. Jeremy's
issues were resolved and I asked if you still had issues. There was
no response so I assumed there were no more objections:
http://www.mail-archive.com/[email protected]/msg02127.html
And Jeremy's final message about implementing it:
http://www.mail-archive.com/[email protected]/msg02133.html
Also, as some more background, checkstyle and PMD enforce our coding
guidelines which were agreed upon and written up a while back, almost
at the start of the project. It would be nice at some point to get
those back on the web site with more explanations on coding practices...
Jim
...ant
On 8/5/06, Jim Marino <[EMAIL PROTECTED]> wrote:
At the risk of throwing stones in a glass house (since I forget to
set svn ignore), *please* remember to run mvn -Psourcecheck prior to
checkins for Java SCA. The Checkstyle audit raises a significant
number of formatting errors that are trivial to avoid by setting
templates in an IDE.
More importantly, PMD fails the build, which is generally a sign of a
potential problem in code. For example, JavaLoggingMonitorFactory
fails with a PMD violation. In this case, it's because the
constructor calls out to an overridable method, which is a bad thing.
There are various areas of the build that are in a state of
disrepair. Can people please clean these up as soon as possible?
Jim
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
