Comments inline.
Simon
Simon Laws wrote:
On 5/16/07, Simon Laws <[EMAIL PROTECTED]> wrote:
On 5/16/07, Simon Nash <[EMAIL PROTECTED]> wrote:
>
> Simon,
> Thanks for committing this. See comments inline below.
>
> Simon
>
> Simon Laws wrote:
> > Ok, I took a look at the patch and committed it. I made a few minor
> > changes:
> >
> > package name changed to crud
> >
> I deliberately changed the package name for the client/application code
> to crudClient to make it different from the package name for the CRUD
> implementation type. This helps to make it clearer which code is
> which, and it is more representative of a typical user scenario
> (which the samples are meant to illustrate). I am also doing this
> with the client/application samples for binding-echo and
> databinding-echo.
>
> What was the rationale for reversing this change?
It was any deep reasoning - just that the capitol C looked strange in the
package name so I took the word out altogether. I could have gone for
crudclient instead.
I'd be fine with crudclient here, and echoappl instead of echoAppl for the
echo-binding-appl sample. I don't know why I did it the other way; habit
from typing variable names I suppose. I do think it's valuable to give
the client/application code a different package name from the extension code.
> include copy of composite file from implementation-crud
> >
> Thanks, I missed this. I did spot it for binding-echo (see my other
> post) but I did not pick up on it for this sample. It should be
> removed from sample-implementation-crud.jar as it does not belong
> there. Moving it to src/test/resources in the implementation-crud
> sample seems to work OK.
OK I can fix that.
> move diagrams from implementation-crud
> >
> I didn't do this because I thought it might be a good idea to update
> the diagrams to show the client side code as well. What do you think?
> What tool do you use to produce these diagrams?
I haven't generally put the client code on the diagram. But I could if it
makes it clearer. I'm using inkscape to produce the svgs
I think this would help, especially for binding-echo-appl where I still
only have a sketchy idea of what the EchoServer.getServer().sendReceive()
call in EchoBindingClient.java is doing :-)
Simon
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
