It would be educational to provide a flavor of the HelloWorld WS / HWWS Client 
sample which used different names in different contexts where the name 
"HelloWorldService" is used today
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

         Key: TUSCANY-232
         URL: http://issues.apache.org/jira/browse/TUSCANY-232
     Project: Tuscany
        Type: Improvement

  Components: Java Samples HelloWorld  
 Environment: Any
    Reporter: Scott Kurz
    Priority: Minor


A confusing aspect of the HelloWorld WS sample is the fact that certain strings 
are repeated
in different contexts.   For example, looking at "HelloWorld WS Client", one 
can see four
distinct usages of the string, "HelloWorldService".

1.  It is the name of the client-side SCA service, which is invoked by the 
HelloWorldClient main() program.
2.  It is the type of the reference variable used in 
HelloWorldServiceComponentImpl to invoke the ES over the WS binding
3.  It is the name of the externalService appearing in sca.module:
           <externalService name="HelloWorldService">
4.  It appears in the client-side WSDL URL in order to match the deployment 
location of the EP-side Hello World WS WAR
           <wsdlsoap:address 
location="http://localhost:8080/helloworldws-SNAPSHOT/services/HelloWorldService"/>

It is certainly instructive that you can overload the string in this way. 
However, it is at the same time confusing to a completely new user as he has to 
sort out which appearances of the "HelloWorldService" string need to stay in 
synch with which other uses, and which do not.

It might be educational to also provide a flavor of the HelloWorld WS sample in 
which distinct names are used in each of these four locations,
e.g.:

HelloWorldClientService
HelloWorldWSInterface
HelloWorldES
HelloWorldService

Another alternative would be to include in the documenation and exercise 
instructing the user to do just this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to