On 4/26/06, Daniel Kulp <[EMAIL PROTECTED]> wrote:
> My information:
> I've attached the "proposed" checkstyle.xml.    In there, there are links
> to checkstyles website that describes each of the checks.   All of the
> checkstyle checks are listed in the file, but many are disabled.  They
> are left in the file so people can see what is available and we can
> decide if we want them enabled or not.
>

-0

I like the idea in theory but have concerns with:
a) the time it takes to run the plugin especially with the number of
modules we have
    is there way it can be run pre-commit?
b) failing the build due to a missing, insignificant space seems harsh
especially
    when there are other more worrying issues like missing tests

Call me naive but I would hope self-discipline (and "reformat code" in
the IDE) would keep layout issues under control and that unit testing
(backed by application of a large fish) would keep bugs under control.

--
Jeremy

Reply via email to