Comments inline.

----- Original Message ----- From: "Raymond Feng" <[EMAIL PROTECTED]>
To: <[email protected]>
Sent: Thursday, October 05, 2006 12:58 AM
Subject: axis2 binding "compile" dependency on core


Hi, Ignacio.

I just found one of your patches added a "compile" dependency on "core" to "binding.axis2". It's from "Axis2CallbackInvocationHandler extends AbstractOutboundInvocationHandler". I don't think it's appropriate to have binding.axis2 depend on core. Can we fix it?

Axis2CallbackInvocationHandler needs to extend AbstractOutboundInvocationHandler to perform most of its handling job. If a dependency on core is not allowed, then other options are:

1- Replicate the logic in binding.axis2 and remove the dependency. I don't think this is a good idea for maintenance reasons. 2- Promote AbstractOutboundInvocationHandler to the spi as an extension point.


We had some discussions before to extract the invocation over interceptor chain into SPI. It seems to be the right way to go.

I am not sure I understand what you mean, can you elaborate?


Thanks,
Raymond



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to