Hi Amita Sorry for taking little longer, but here are some comments on your updates:
I have incorporated your changes to DataAccessComponentTypeLoader Changes to DataAccessEngine.java are assuming that the container should be responsible to setup database, and I don't believe that is the right place to do that, the application should be responsible for creating the database, and either dasConfig.xml or SCDL should only have necessary information to connect to the database. Maybe this is being done trying to overcome the current DAS config.xml limitation when running in a J2SE environment, but then we should find the proper way to solve that. As for a drive program, I think we should make this as an unit testing, or a sample app... I'll try refactor the driver program you were using. I've posted my patch with some of your changes at my sandbox, we can start collaborating with patches from there : https://svn.apache.org/repos/asf/incubator/tuscany/sandbox/lresende/ -- Luciano Resende http://people.apache.org/~lresende On 11/15/06, Luciano Resende <[EMAIL PROTECTED]> wrote:
Thank you, I'll take a look at your changes when it's available... For the J2SE code, it should be ok for now... I just don't want to have a copy of the canned db bundled together... - Luciano On 11/15/06, Amita Vadhavkar <[EMAIL PROTECTED]> wrote: > > Hi Luciano, > I had done a few changes and will be attaching the working code to > JIRA in next couple of hours. Just wanted to update you for same and > will start looking at the > test case development after that. > > (Please note, for the basic testing to check that the code is working, > I have still > kept the old J2SE code for data connection etc. After the J2EE setup > can clean that part too.) > > Regards, > Amita > > On 11/14/06, Luciano Resende <[EMAIL PROTECTED]> wrote: > > Hi All > > > > I have updated (Tuscany-904) with a new version of the DAS > container. > > This is based on the initial contribution that Amita did, with some > > clean-up, refactoring and additions to try to fix a possible problem > with > > mutable properties that are shared among instance (pointed by Jim > Marino)... > > Currently, this is just the initial drop that I want to make available > in > > the trunk so other can start to take a look and Amita and I could > > collaborate easier... unit testings, sample, etc are coming... I'd > > appreciate if anyone could help get this to the trunk if there is > nothing > > wrong with this... > > > > Couple Questions: > > > > Could someone take a quick look at ComponentTypeLoader and see if it's > > looking Ok ? I was not sure about what this loadFromSideFile means ? > what is > > the "side file"? Is this something particular to Script container ? > > > > Also, I wasn't sure what time is the appropriate time to load the das > config > > file when provided ? Right now is being loaded at > > DataAccessImplementationLoader, if you guys think this should go in a > > different place, please let me know... also would be good to know why > :) > > > > Well, comments and feedback are welcome... Note that I'm still getting > > > familiar with the Container SPI, so, please let me know if I > misunderstood > > something on the implementation. > > > > - Luciano Resende > > Apache Tuscany > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
