[ 
https://issues.apache.org/jira/browse/TUSCANY-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487795
 ] 

Dan Murphy commented on TUSCANY-1181:
-------------------------------------

Hi Kelvin...
I don't have Tortoise SVN (since I run linux) so I'm not sure how much 
investigation I can do... the patch looks reasonable to me (as in, I look at it 
with an editor and don't see anything obvious;y wrong with it). It may be 
because the XSDHelperTest was a rename of the XSDSerialisationTests... From the 
description you give it sounds like the patch applied, but has not been added 
to svn (?)...

> XSDSerializationTest is Tuscany-specific
> ----------------------------------------
>
>                 Key: TUSCANY-1181
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1181
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SDO Community Test Suite
>            Reporter: Andy Grove
>         Attachments: Tuscany-1181.patch
>
>
> XSDSerializationTest contains assertions like the following that expect 2 
> types to be created from simple.xsd, which just contains a single type called 
> "Quote".
> assertEquals("XSDHelper.define() did not create the expected number of 
> Types", 2, types.size());
> Presumably the current assertion is based on DocumentRoot being in the types 
> list.
> It would be better to check that the "Quote" type is in the list rather than 
> just checking the size of the list.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to