Need to refactor some classes and interfaces to make it clear what is part of
the SPI
-------------------------------------------------------------------------------------
Key: TUSCANY-1281
URL: https://issues.apache.org/jira/browse/TUSCANY-1281
Project: Tuscany
Issue Type: Bug
Components: Java SCA Kernel
Affects Versions: Java-SCA-0.90
Environment: Windows XP
Reporter: Simon Nash
Assigned To: Simon Nash
Fix For: Java-SCA-Next
We need to clearly identify which classes are part of the SPI and which classes
are implementation code that is not exposed as part of the SPI. See
http://www.mail-archive.com/[email protected]/msg17575.html and the
discussion from
http://www.mail-archive.com/[email protected]/msg17590.html quoted
below:
>>> 5. The org.apache.tuscany.assembly.xml package seems to contain
>>> implementation classes that aren't in an "impl" subpackage.
>>
>>
>>
>> I'm not sure that we want all non spi packages to be *.impl. In
>> general I think we should avoid extremes, like:
>> - have all spis in *.spi.* packages
>> - or have all non spi in *.impl packages
>>
>> Looking at other Apache projects, many seem to follow a more
>> reasonable and balanced approach, which I hope we can do as well.
>>
> I replied to this on a separate thread.
>
>>> 6. The bindings don't seem to follow the "impl" subpackage convention,
>>> except for binding-ws.
>>> 7. None of the core subpackages follow the "impl" subpackage
>>> convention. They are called component, event, invocation, runtime,
>>> store, util, and work.
>>
>>
>>
>> We need to refactor these packages, these modules do not offer SPIs so
>> it's not necessarily very bad. I'd suggest the following:
>> - open JIRAs for this, to avoid losing these issues in the flow of emails
>> - evaluate their priority and stage this work, I'd suggest to do this
>> kind of refactoring after we have stabilized the function
>> - find volunteers to do this work :)
>>
> The core does offer SPIs. These are in a separate core-spi module in the
> svn repository, but when we build a release distribution they will (I
> presume)
> be in the tuscany-all jar together with the core implementation code, and
> not very clearly distinguished from it. For now I'll open a JIRA to track
> the issue. I am willing to do this refactoring at a suitable time if we
> can agree on a convention that everyone is OK with.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
