[
https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Nash updated TUSCANY-1500:
--------------------------------
Attachment: patch1
Here is patch1 for this JIRA. It enables the callback-api test in the build
and gets it working. Here's a summary of the changes in this patch.
1. Rename CallBackApiTestCaseFIXME.java to CallBackApiTestCase.java. (NOTE:
This must be done manually before applying the patch, which contains an update
to CallBackApiTestCase.java.)
2. Change the class name for the test from CallBackApiTestCaseFIXME to
CallBackApiTestCase.
3. Change the test code that gets the callable reference to use the correct
spec APIs.
4. Move the code in JDKCallbackInvocationHandler that clones and binds the
selected dynamic wire into CallbackWireObjectFactory so that it can be executed
when callable references are created as when as when callback invocations are
made.
5. Restore the factory.resolveTarget() call in
RequestContextImpl.getCallbackReference() that was commented out. This selects
a wire and endpoint for the callback so that this becomes part of the callable
reference.
6. Make RequestContextImpl.getCallbackReference() return a
CallableReferenceImpl object instead of a service reference. (This was being
done previously but was inadvertently changed by an overlapping update.)
7. Restrict the constructors in CallableReferenceImpl to protected as we don't
want to open up direct instantiation of these objects to application code.
I am looking at the other failing callback tests and I will post further
patches to get them working.
> Many callback tests don't run
> -----------------------------
>
> Key: TUSCANY-1500
> URL: https://issues.apache.org/jira/browse/TUSCANY-1500
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-Next
>
> Attachments: patch1
>
>
> The following itests are currently disabled in the build. If they are
> enabled by changing the name of the test class from xxxTest to xxxTestCase,
> they fail with various errors.
> callback-api
> callback-complex-type
> callback-id
> callback-set-callback
> callback-set-conversation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
