Scott Kurz wrote:
Hi Raymond, Sebastien,

Sorry I dropped off of the discussion for awhile.  I took a look at
the r628163 code.

Let me see if I'm understanding this correctly:

When an Invoker implements PassByValueAware.allowsPassByReference()
and returns 'true', it means exactly this:
  "I know that, on this chain, the PBVInterceptor won't need to do a copy".

So a binding invoker might set this on the chain knowing that the
binding has done a copy, or the JavaImpl invoker (if the @AllowsPBR is
detected on the Java impl), or the DataTransformationInterceptor
might, assuming that if this interceptor is set up on the wire, then a
copy must always be done.

I had a hard time grasping this at first, I think because the name
threw me off, until I started thinking of it in terms of:
"noCopyByPBVInterceptorNeededOnThisChain()".

Did I get this right?

Yes. You can say "noCopyByPBVInterceptorNeededOnThisChain" when the head invoker "allowsPassByReference...withoutMessingUpYourData".

Assuming I did, it looks like a nice improvement.

Cool :)

[snip]
I still wonder whether it's a good or bad assumption to assume the
DTInterceptor always does a copy, since I found a use for it when it
did not (but again that was a more ugly use).


I wouldn't make that assumption as it depends on the nature of the transformation but with the new design the interceptor gets to decide and give the proper answer, no assumption is needed.
--
Jean-Sebastien

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to