Comments inline
On Sat, Apr 12, 2008 at 10:42 AM, sebb <[EMAIL PROTECTED]> wrote:
> On 10/04/2008, Luciano Resende <[EMAIL PROTECTED]> wrote:
> > Please review and vote on the 1.2 release artifacts of Tuscany SCA for
> Java.
> >
> > The artifacts are available for review at:
> > http://people.apache.org/~lresende/tuscany/sca-1.2-RC3b/
>
> Sigs and hashes all OK.
>
>
> > This includes the signed binary and source distributions, the RAT report,
>
> The source archive contains the empty directory tree
> modules/osgi-runtime/.felix, which is not in SVN. It should be
> removed.
This is a minor thing, but I have fixed this in the sca 1.2 branch anyway.
>
> Likewise, the source contains itest/transaction/derbydb, which is not in SVN.
This is a minor thing, but I have fixed this in the sca 1.2 branch anyway.
>
> mvn reports quite a few warnings when testing - e.g.
> 12-Apr-2008 15:53:29
> org.apache.tuscany.sca.contribution.processor.ExtensibleStAXArtifactProcessor
> read
> WARNING: Element
> {http://www.osoa.org/xmlns/sca/1.0}implementation.java cannot be
> processed. ([row,col {unknown-source}]: [50,9])
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.094 sec
>
> Are these expected?
Yes
>
> There is an odd file:
>
> modules/core-databinding/src/test/java/org/apache/tuscany/sca/core/databinding/transformers/IDLTransformerTestCase.java.fixme
> which probably shoul be removed.
>
I also see this as very minor.
> Minor nits:
>
> BUILDING says:
> "Change to the distributions folder"
> that should be
> "Change to the distribution folder"
>
Minor, but also fixed on the sca 1.2 branch.
> It would also be useful to warn people that the build needs lots of memory,
> e.g. they may need to:
> set MAVEN_OPTS=-Xmx128M (or more)
> before attempting a build.
>
Minor, but also fixed in the sca 1.2 branch.
>
> > and the Maven staging repository.
> >
>
> The maven.xml descriptor at
>
> http://people.apache.org/~lresende/tuscany/sca-1.2-RC3b/maven/org/apache/tuscany/sca/
> only refers to the 5 tuscany-maven-* directories. There are lots more.
> Should they not be included? I don't know nada about M2 repos, so I
> could be wrong.
>
This is OK, these are the 5 maven tools we have from :
https://svn.apache.org/repos/asf/incubator/tuscany/branches/sca-java-1.2/tools/maven/
>
> > The eclipse updatesite for the Tuscany Eclipse plugins is available at:
> > http://people.apache.org/~lresende/tuscany/sca-1.2-RC3b/updatesite/
> >
>
> The plugins jar NOTICE is different from the features jar NOTICE.
> Even though the features jar does not contain any non-ASF code, it is
> not usable without the plugins jar, so I would expect them to have the
> same attributions.
>
As you mentioned, the features jar does not have any non-ASF code...
> The top-level NOTICE agrees with the plugins jar which is good.
>
and the top-level NOTICE handles all license and notices.
for now, to follow the same pattern used in all other modules, I have
left it as is.
>
> > The release tag is available at :
> > http://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sca/1.2-RC3b/
> >
> >
> > Looks OK to me, here is my +1.
> >
> >
> > --
> > Luciano Resende
> > Apache Tuscany Committer
> > http://people.apache.org/~lresende
> > http://lresende.blogspot.com/
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
--
Luciano Resende
Apache Tuscany Committer
http://people.apache.org/~lresende
http://lresende.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
