On Thu, Apr 10, 2008 at 10:05 PM, Simon Laws <[EMAIL PROTECTED]> wrote:
> Hi Hasan > > On Thu, Apr 10, 2008 at 9:34 PM, Hasan Muhammad <[EMAIL PROTECTED]> wrote: > > > Hi Simon, > > > > I dont think using an underlying tuscany jdk logger would be useful to > > plugins as they may not want to log, rather show it somewhere else such > > as > > console etc. > > > > Agreed. Thinking about this some more it is also bad as we may not have > control of the loggers that and embedding system uses. > > > > Tuscany can use an underlying logger in it's own monitor ( as > > it uses today). But i think the first approach of using a monitor is > > better > > along with the condition that it be made more usable by the plugins by > > giving them greater control. > > > Yep > > > > > > > > Another point is that tuscany should use ResourceBundle for validation > > messages as well. I dont think this is being done today. > > > +1 > > > So I'm making a itest for validation cases. I'm starting with the one you > kicked off with, i.e. the schema validation one. Have you got any other > scenarios in mind? > > Hi I've just checked in some code [1][2] that, for now, separates the monitor interface for the interface in assembly (monitor) and also provides a pluggable monitor implementation (monitor-impl). I haven't applied it back into the assembly builder validation but am exposing it here for comment while I start to look at this. The intention remains as it currently is, i.e. to capture all the problems that occur during the various validation processes that Tuscany undertakes. As the implementation is pluggable others can introduce a new monitor to cache problems and deal with them in whatever way is appropriate. The default implementation continues to log problems to the JDK logger. Now though messages are expected to be identified by ID and located in resource bundles. A specific question. The existing problem class has the notion of resources. What are resources in this context? Regards Simon [1] http://svn.apache.org/repos/asf/incubator/tuscany/java/sca/modules/monitor/ [2] http://svn.apache.org/repos/asf/incubator/tuscany/java/sca/modules/monitor-impl/
