Luciano,

 I don't think including Derby is a must-have for M2, though it would
be nice to avoid having that extra setup step. It's not worth holding
a release.

Brent

On 10/11/06, Luciano Resende <[EMAIL PROTECTED]> wrote:
Hi Brent

  I spent little more time around your comments, and I'm trying to address
them to a possible DAS RC3.
  See my comments below :

>>2) The appendix in the readme.htm is out of date. It
>>mentions some file locations for step 4, but there is no
>>longer a step 4 and the locations are irrelevant now that
>>we don't need to copy these files.

Item 4 describes only derby.jar file to be copied to TC installation. The
appendix have a list of all dependencies files, and explicitly have a note
saying that CompanyWeb have all dependencies in WEB-INF\lib except for the
derby one. I'm creating a patch to get it a little more clear, but I was
planning to leave the list of dependencies on the appendix.

>>4) Should the sample webapp include the derby jar? It
>> seems reasonable since we are including SDO, EMF,
>> etc. It would be nice if we didn't require users to copy
>> this over.

Regarding including derby, do you think this is a MUST ? The documentation
is already addressing the necessary steps to get derby configured and even
if you include the jar, you still have to go and configure the dataSource.

- Luciano Resende


On 10/11/06, Luciano Resende <[EMAIL PROTECTED]> wrote:
>
> Thanks for the quick feedback...
> My comments inline
>
>
> On 10/11/06, Brent Daniel <[EMAIL PROTECTED]> wrote:
> >
> > Hey Luciano,
> >
> > Just took a quick look at this. I havn't gone through and tried to run
> > anything yet but I did notice a few things (I can look into fixing
> > some of these later.)
> >
> > 1) The RC2 files are named M2-SNAPSHOT rather than M2-RC2.. Not really
> > a big deal but we should maintain consistency here.
>
>
>
> This is following the same naming as SDO, but the final RC should move to
> RC naming...
>
>
> 2) The appendix in the readme.htm is out of date. It mentions some
> > file locations for step 4, but there is no longer a step 4 and the
> > locations are irrelevant now that we don't need to copy these files.
>
>
>
> I'll look into that..
>
>
> 3) STATUS.txt still looks out of date.. The version at
> > http://svn.apache.org/repos/asf/incubator/tuscany/STATUS has a full
> > list of committers but this one does not
>
>
>
> The Status.txt is being updated frequently...this might be because some
> changes went in into the trunk version after I grabed a copy of it.
>
>
> 4) Should the sample webapp include the derby jar? It seems reasonable
> > since we are including SDO, EMF, etc. It would be nice if we didn't
> > require users to copy this over.
>
>
> I didn't explicitly add that there because the readme tells users to grab
> derby and then put the database in place and configure datasources, do we
> want to remove these instructions and ship derby together in the samples ?
>
>
> 5) Did we decide against changing the sample location from "bin" to
> > something else? Does anyone else have an opinion on where this should
> > go? "bin" seems like a place for executables and scripts, not a war
> > file.
>
>
>
> This was the only thing i didn't change in the structure, but if you have
> strong feelings to have this changed, i'll do it.
>
>
> Brent
> >
> >
> > On 10/11/06, Luciano Resende <[EMAIL PROTECTED] > wrote:
> > > The DAS Java M2 Release Candidate is available at :
> > >
> > >      
http://people.apache.org/~kelvingoodson/das_java/RC2/<http://people.apache.org/%7Ekelvingoodson/das_java/RC2/>
> > >
> > > Changes from DAS Java M2 - RC1
> > >
> > >   I have addressed most of issues from the feedback you guys gave me
> > on
> > > RC1, see thread below :
> > >
> > >      
http://www.mail-archive.com/tuscany-user%40ws.apache.org/msg00242.html
> > >
> > > What's new in DAS Java M2
> > >
> > >   DAS Core features
> > >
> > >      - MySQL support
> > >      - Static Data Objects
> > >      - Dynamic root for static graphs
> > >      - "Unique" attribute on relationships
> > >      - Explicit ResultSet shape definition
> > >      - Improved logging
> > >      - Programmatic Configuration
> > >      - Helper for empty SDO Graph
> > >      - Convention over configuration
> > >         - Column named "ID" is the PK
> > >         - Column named "xxx_ID" is the FK to table "xxx"
> > >
> > >   DAS Samples
> > >      - Tomcat integration and automated DAS samples testing (htmlUnit)
> > >      - DAS Samples now have all dependencies and source code inside
> > the
> > > sample war
> > >
> > >   For detailed user documentation and feature descriptions, access
> > Tuscany
> > > DAS Wiki page
> > >      http://wiki.apache.org/ws/Tuscany/TuscanyJava/DAS_Java_Overview
> > >
> > > Please take a look at it and provide your feedback.
> > >
> > > Thanks
> > > Luciano Resende
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to