> On Mar 16, 2015, at 2:17 AM, Adi Roiban <a...@roiban.ro> wrote:
>
> Hi
>
> I know that twisted main repo contains a lot of code but I would like
> to discuss the option of merging
> twisted-dev-tools and twistedchecker into twisted main repo.
>
> The main reason why I want this is to make reviews for these repos
> more visible to twisted developers.
>
> I don't think that we would have a different team of developers
> working on twisted and another one on twisted tools and twistedchecker
>
> I understand that twistedchecker was started as a SOC project and I
> agree that is much easier to start as a separate project, but not I
> feel that having a different repo does not help.
I'm approximately -0 on this. I don't like the idea of dumping a bunch of code
into the main Twisted repo that isn't distributed along with Twisted
(personally I cannot wait to get rid of the "admin" directory entirely), but I
also see your point about the tool being a part of the process.
> Twistedchecker has become an important part of dev process and I feel
> that the reviews for this project are should be more visible.
> For example my PRs for twistedchecker are unreviewed on GitHub for
> more than on mouth and there are many other reviews laying idle
To be fair we are only just now getting down to a reasonable latency on Twisted
reviews, and it is still a fairly small audience reviewing. This may just
lengthen the Twisted review queue :).
So, I do have an alternate proposal - perhaps you should just announce changes
to twistedchecker on this list, and land changes to it without review if nobody
objects within a week or so. If you're making changes that are time-sensitive
and there is an insufficient community to participate in reviews, then I think
it's fair to say that they shouldn't be reviewed. If anyone objects to the
changes that are going in, they can always sign up to do reviews :). I have
implicitly instituted such a process for Twisted-umbrella projects like
Imaginary and Vertex, where there are not enough active contributors to sustain
development.
> Maybe there is another reason why those PR are not reviewed and
> merging twistechecker and twisted-dev-tools will not help with having
> those PR reviewed faster but I would like to investigate this issue
> and look for solutions.
>
> What do you think?
>
> I have also filled this ticket
> https://github.com/twisted/twisted-dev-tools/issues/11
>
> I think that reviewing patched in less than 2 weeks is critical for
> having an active open source project and expecting for developers to
> send more patches.
Thanks for looking into this, and for all your work making it more pleasant to
develop Twisted,
-glyph
_______________________________________________
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
