Hello Twisted, I'd like to help landing this code too, but exactly as Werner said, reviewing Twisted code can feel a bit intimidating. As an example, I tried this branch and the code samples. They work fine, and are easy to follow along.
I also read the PR and Adi's review, and that's when things started to get a bit complicated. I got lost in the subtilities of testing, and interfaces. Just to be clear, this is not a complaint at all :). I fully understand that the Twisted codebase is complex, and that it takes a while to be familiar with. I'm just trying to convey my feeling of "I'd like to help, but I'm struggling to bring something to the PR, apart from some very minor remarks". Twisted is by far my favorite Python project, and I find incredible that it still has momentum almost 25 years after its first release. Thank you Glyph, Adi, and others for your dedication during all these years. -- Greg
_______________________________________________ Twisted mailing list -- twisted@python.org To unsubscribe send an email to twisted-le...@python.org https://mail.python.org/mailman3/lists/twisted.python.org/ Message archived at https://mail.python.org/archives/list/twisted@python.org/message/5QPHCNBPUGH7E7RTZECX3PECBGTPA5BG/ Code of Conduct: https://twisted.org/conduct
