Hi Greg Thanks for your message.
If you are happy with the documentation and the examples, feel free to leave a message on any PR. This is valid feedback for the devs working on that PR Reviewing the documentation and the example is as important as the code review... maybe even more important. If you have time, you can do some manual testing. For example run some "negative tests", try to trigger some errors or call the API with invalid values. Check that the error message makes sense and it's easy to understand what needs to be done to fix the errors. This is an example where it's very useful to have a review from someone that is not "attached" to the source code. For example, the developer of the PR might observe an error, but might not notice that the error message is not intuitive. There is not much use to have advanced features in Twisted, as long as the API is hard to use or hard to understand and nobody is using that code. Any review is important and you don't have to review the full spectrum of that code. And if we get help with reviewers validating the documentation, it means that other devs can focus their review on the low-level code. Cheers On Tue, 29 Apr 2025 at 17:32, Grégoire JUGE via Twisted <twisted@python.org> wrote: > Hello Twisted, > > I'd like to help landing this code too, but exactly as Werner said, > reviewing Twisted code can feel a bit intimidating. > As an example, I tried this branch and the code samples. They work fine, > and are easy to follow along. > > I also read the PR and Adi's review, and that's when things started to get > a bit complicated. > I got lost in the subtilities of testing, and interfaces. > > Just to be clear, this is not a complaint at all :). > I fully understand that the Twisted codebase is complex, and that it takes > a while to be familiar with. > I'm just trying to convey my feeling of "I'd like to help, but I'm > struggling to bring something to the PR, apart from some very minor > remarks". > > Twisted is by far my favorite Python project, and I find incredible that > it still has momentum almost 25 years after its first release. > > Thank you Glyph, Adi, and others for your dedication during all these > years. > > -- > Greg > _______________________________________________ > Twisted mailing list -- twisted@python.org > To unsubscribe send an email to twisted-le...@python.org > https://mail.python.org/mailman3/lists/twisted.python.org/ > Message archived at > https://mail.python.org/archives/list/twisted@python.org/message/5QPHCNBPUGH7E7RTZECX3PECBGTPA5BG/ > Code of Conduct: https://twisted.org/conduct > -- Adi Roiban
_______________________________________________ Twisted mailing list -- twisted@python.org To unsubscribe send an email to twisted-le...@python.org https://mail.python.org/mailman3/lists/twisted.python.org/ Message archived at https://mail.python.org/archives/list/twisted@python.org/message/JLTGLJMPDTSQH66OZUBE5KEIZXINDA5D/ Code of Conduct: https://twisted.org/conduct
