Hi Lukasz,
On 5/15/25 5:55 PM, Lukasz Czechowski wrote:
The RAM_ROCKCHIP_DEBUG can be used only if DEBUG_UART is
available, otherwise it won't have any effect.
I think it used to have an effect before patch 2/5 no?
If that is the case, I would recommend to reorder the patches so that
3/5 is before 2/5 and in the commit log you explain that the next commit
is going to require DEBUG_UART to be defined in order to be able to use
printch/printascii/... That way, expected behavior won't change (i.e. if
I checkout at patch 2/5, I don't get anything on the serial anymore, but
I do if I checkout 1/5 or 3/5).
Looks good to me otherwise:
Reviewed-by: Quentin Schulz <quentin.sch...@cherry.de>
Thanks!
Quentin
